Add ITA Verifier Client #530
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessieqliu
force-pushed
the
ita_client
branch
from
5a3eb4a to
be20d42
Compare
jessieqliu
force-pushed
the
ita_client
branch
from
6ddb78d to
7b9f778
Compare
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
1 similar comment
|
/gcbrun |
jkl73
reviewed
Feb 5, 2025
| InsecureSkipVerify: false, | ||
| MinVersion: tls.VersionTLS12, | ||
| }, | ||
| Proxy: http.ProxyFromEnvironment, |
There was a problem hiding this comment.
Do we really need the proxy setting?
There was a problem hiding this comment.
Added this since it was in the example ITA sent me. I can test it out without the setting and remove it if needed.
| type itaNonce struct { | ||
| Val []byte `json:"val"` | ||
| Iat []byte `json:"iat"` | ||
| Signature []byte `json:"signature"` |
There was a problem hiding this comment.
Is verifying the Signature needed? Maybe in createHashedNonce
There was a problem hiding this comment.
We don't need to verify the signature - this should be done by ITA. We should - however - pass the nonce object back to ITA when requesting a token.
verifier/ita/client.go
Outdated
| } | ||
|
|
||
| // Do we have anything that needs to be in user data? | ||
| // _, err = hash.Write(adapter.uData) |
|
/gcbrun |
|
/gcbrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.